refactor(2meet-data-optimizer-hivepress-addon): stop registering Hot zone fields

- ADR-003 step 4 (AddOn side): core, requests, bookings, memberships and
  marketplace adapters no longer register zone=hot fields or contribute
  hot_* FSM modules; their keys live in TMDO_HivePress_Entity_Groups.
  Cold/warm registrations are unchanged.
- Hot-table doctor probes go with them (trait defaults apply). The
  hot-clause query rewrite and cron optimizer are now inert and are left
  for the ADR step-5 removal together with core's hot path.
- New NoHotZoneRegistrationTest pins the invariant across all 13 adapters;
  per-adapter hot assertions removed.
- Verify: HP unit 142 / integration 49 green, phpcs clean (WordPress)
- PR: PR-037

includes/hivepress/adapters/class-tmdo-hivepress-core-adapter.php

@@ -4,13 +4,14 @@
  *
  * Covers the primary HivePress models:
  *
- *   - `Listing` (post_type=hp_listing) — Hot zone columns for search/filter
- *     (drafted, featured, verified, expired_time, featured_time).
- *   - `Vendor`  (post_type=hp_vendor)  — Hot column `verified`; cold blob
- *     for image / description (display-only).
+ *   - `Listing` (post_type=hp_listing) — cold blob for the gallery.
+ *   - `Vendor`  (post_type=hp_vendor)  — cold blob for the image.
  *   - `User`    (entity=user)          — no zone fields; its `hp_user`
  *     entity group is registered by TMDO_HivePress_Entity_Groups.
  *
+ * Search/filter keys are flattened by TMDO_HivePress_Entity_Groups
+ * (ADR-003: no Hot zone fields).
+ *
  * This adapter SUPERSEDES the legacy `class-tmdo-hivepress.php` (242 lines).
  * Behavioural parity:
  *
@@ -23,11 +24,6 @@
  *     adapter only registers `hivepress` core fields.
  *   - Vendor cold fields (`hp_image`, `hp_images`) — preserved.
  *
- * NEW additions vs legacy:
- *
- *   - `hp_drafted` (Listing) — Hot tinyint(1) for user-dashboard filtering.
- *   - `hp_expired_time` / `hp_featured_time` (Listing) — Hot bigint indexed
- *     for cron expiry scan acceleration (replaces postmeta full scan).
  *   (This adapter used to register a second `hp_user` definition —
  *   hp_verified / hp_avatar_id, keys HivePress never writes — which the
  *   registry silently dropped; TMDO_HivePress_Entity_Groups owns it now.)
@@ -114,37 +110,10 @@ if ( ! class_exists( 'TMDO_HivePress_Core_Adapter' ) ) {
 		 * @param TMDO_Schema_Registry $registry Schema registry singleton.
 		 */
 		public function on_register_fields( TMDO_Schema_Registry $registry ): void {
-			// ── Listing hot fields (search/filter accelerators) ──
+			// ── Cold blobs (display-only) ──
 			$registry->register_many(
 				$this->plugin_slug(),
 				array(
-					// Drafted — used in user dashboard "my drafts" filter.
-					array(
-						'post_type' => 'hp_listing',
-						'meta_key'  => 'hp_drafted',
-						'zone'      => 'hot',
-						'data_type' => 'tinyint(1) NOT NULL DEFAULT 0',
-						'column'    => 'hp_drafted',
-						'indexed'   => true,
-					),
-					// Expired time — replaces `meta_query` clause in hourly cron.
-					array(
-						'post_type' => 'hp_listing',
-						'meta_key'  => 'hp_expired_time',
-						'zone'      => 'hot',
-						'data_type' => 'bigint(20) UNSIGNED NOT NULL DEFAULT 0',
-						'column'    => 'hp_expired_time',
-						'indexed'   => true,
-					),
-					// Featured time — same expiry pattern as above.
-					array(
-						'post_type' => 'hp_listing',
-						'meta_key'  => 'hp_featured_time',
-						'zone'      => 'hot',
-						'data_type' => 'bigint(20) UNSIGNED NOT NULL DEFAULT 0',
-						'column'    => 'hp_featured_time',
-						'indexed'   => true,
-					),
 					// Vendor cold blob — image attachment id (display-only).
 					array(
 						'post_type'   => 'hp_vendor',
@@ -276,57 +245,6 @@ if ( ! class_exists( 'TMDO_HivePress_Core_Adapter' ) ) {
 
 		// ── Doctor / score / migrations ────────────────────────────────────
 
-		/**
-		 * Health probe: verify hot tables exist + sample row count.
-		 *
-		 * @return array{ok:bool, message:string, details?:array<string,mixed>}
-		 */
-		public function doctor_check(): array {
-			global $wpdb;
-			if ( ! isset( $wpdb ) || ! is_object( $wpdb ) ) {
-				return array(
-					'ok'      => false,
-					'message' => 'wpdb global not available',
-				);
-			}
-
-			$details = array();
-			$ok      = true;
-			foreach ( self::HOT_MODELS as $post_type ) {
-				$table = $wpdb->prefix . 'wpdo_hot_' . sanitize_key( $post_type );
-				try {
-					$exists                = (bool) $wpdb->get_var(
-						$wpdb->prepare( 'SHOW TABLES LIKE %s', $table )
-					);
-					$details[ $post_type ] = array(
-						'table'  => $table,
-						'exists' => $exists,
-					);
-					if ( $exists ) {
-						$details[ $post_type ]['rows'] = (int) $wpdb->get_var(
-							"SELECT COUNT(*) FROM `{$table}`" // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared -- Sanitized via sanitize_key + wpdb prefix.
-						);
-					} else {
-						$ok = false;
-					}
-				} catch ( \Throwable $e ) {
-					$details[ $post_type ] = array(
-						'table' => $table,
-						'error' => $e->getMessage(),
-					);
-					$ok                    = false;
-				}
-			}
-
-			return array(
-				'ok'      => $ok,
-				'message' => $ok
-					? 'hivepress core: hot tables OK'
-					: 'hivepress core: one or more hot tables missing or unreadable',
-				'details' => $details,
-			);
-		}
-
 		/**
 		 * 8-dimension self-score for the core adapter.
 		 *
@@ -348,18 +266,6 @@ if ( ! class_exists( 'TMDO_HivePress_Core_Adapter' ) ) {
 				)
 			);
 		}
-
-		/**
-		 * FSM modules this adapter contributes.
-		 *
-		 * @return array<int,string>
-		 */
-		public function migrations(): array {
-			return array(
-				'hot_hp_listing',
-				'hot_hp_vendor',
-			);
-		}
 	}
 
 } // end if ( ! class_exists )