refactor(2meet-data-optimizer-hivepress-addon): remove comment mirror writes to never-created tables
- Favorites/Messages adapters reduced to detection only; Requests keeps hot_hp_request fields, drops hp_offer mirror - Delete TMDO_HivePress_Comment_Router (read path to wpdo_comment_hp_* tables that no installer creates) - Verify: addon unit 141 OK, integration 52 OK; phpcs 41E/57W → 35E/48W - PR: PR-013
This commit is contained in:
@@ -48,54 +48,29 @@ class HivePressRequestsAdapterTest extends TestCase {
|
||||
$this->assertTrue( (bool) $expired['indexed'] );
|
||||
}
|
||||
|
||||
public function test_on_register_custom_tables_declares_offer_shadow(): void {
|
||||
public function test_registers_no_offer_shadow_table(): void {
|
||||
// The offer shadow table was never created, so every mirror write failed.
|
||||
$registry = WPDO_Custom_Table_Registry::instance();
|
||||
$this->adapter->on_register_custom_tables( $registry );
|
||||
|
||||
$tables = $registry->all();
|
||||
$cfg = reset( $tables );
|
||||
$this->assertSame( 'wpdo_comment_hp_offer', $cfg['table_name'] );
|
||||
$this->assertSame( 'hp_request', $cfg['post_type_link'] );
|
||||
$this->assertArrayHasKey( 'idx_request_approved', $cfg['indexes'] );
|
||||
$this->assertSame( array(), $registry->all() );
|
||||
}
|
||||
|
||||
public function test_mirror_offer_insert_skips_other_comment_types(): void {
|
||||
global $wpdb;
|
||||
$wpdb->queries = array();
|
||||
public function test_binds_no_comment_hooks(): void {
|
||||
$GLOBALS['_wp_filter_callbacks'] = array();
|
||||
|
||||
$comment = new stdClass();
|
||||
$comment->comment_type = 'comment'; // ← not hp_offer
|
||||
$comment->comment_post_ID = 99;
|
||||
$comment->user_id = 1;
|
||||
$this->adapter->on_register_event_hooks();
|
||||
|
||||
$this->adapter->mirror_offer_insert( 1, $comment );
|
||||
$this->assertSame( array(), $wpdb->queries );
|
||||
}
|
||||
|
||||
public function test_mirror_offer_insert_writes_for_hp_offer(): void {
|
||||
global $wpdb;
|
||||
$wpdb->queries = array();
|
||||
|
||||
$comment = new stdClass();
|
||||
$comment->comment_type = 'hp_offer';
|
||||
$comment->comment_post_ID = 42;
|
||||
$comment->user_id = 7;
|
||||
$comment->comment_approved = 0;
|
||||
$comment->comment_date = '2026-05-04 12:00:00';
|
||||
|
||||
$this->adapter->mirror_offer_insert( 100, $comment );
|
||||
$this->assertCount( 1, $wpdb->queries );
|
||||
$this->assertStringContainsString( 'INSERT INTO', $wpdb->queries[0] );
|
||||
$this->assertStringContainsString( 'wpdo_comment_hp_offer', $wpdb->queries[0] );
|
||||
$this->assertArrayNotHasKey( 'wp_insert_comment', $GLOBALS['_wp_filter_callbacks'] );
|
||||
$this->assertArrayNotHasKey( 'edit_comment', $GLOBALS['_wp_filter_callbacks'] );
|
||||
$this->assertArrayNotHasKey( 'deleted_comment', $GLOBALS['_wp_filter_callbacks'] );
|
||||
}
|
||||
|
||||
public function test_score_aggregates_to_perfect_ten(): void {
|
||||
$this->assertSame( 10.0, $this->adapter->suitability_score()['aggregate'] );
|
||||
}
|
||||
|
||||
public function test_migrations_lists_request_and_offer_modules(): void {
|
||||
$mods = $this->adapter->migrations();
|
||||
$this->assertContains( 'hot_hp_request', $mods );
|
||||
$this->assertContains( 'comment_hp_offer', $mods );
|
||||
public function test_migrations_lists_only_request_hot_module(): void {
|
||||
$this->assertSame( array( 'hot_hp_request' ), $this->adapter->migrations() );
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user