hardening 2.0: 2meet-data-optimizer (staged rollout, dev22 first) #3

Merged

wpdev merged 30 commits from hardening/2.0 into main 2026-09-26 10:20:24 +08:00

Conversation 0 Commits 30 Files Changed 89

+6448 -1382

wpdev commented 2026-09-26 07:29:23 +08:00

Owner

Copy Link

Copy Source

Hardening 2.0 for 2meet-data-optimizer — the backlog PRs committed on hardening/2.0 (see dev30/notes/pr-backlog.md, Completed Log).

Commits

• fix(2meet-data-optimizer): compare empty strings correctly when retiring a group
• refactor(2meet-data-optimizer): retire the SSO AddOn recommendation
• feat(2meet-data-optimizer): group-scoped native write-back and group retirement
• refactor(2meet-data-optimizer): stop registering the sso group in core
• perf(2meet-data-optimizer): cache found-rows counts for routed queries
• perf(2meet-data-optimizer): route status and date ordering to entity tables
• feat(2meet-data-optimizer): store post_status and post_date copies in post entity tables
• feat(2meet-data-optimizer): flag new Hot zone registrations as deprecated
• feat(2meet-data-optimizer): support composite indexes on entity groups
• docs(2meet-data-optimizer): decide hot table vs entity table consolidation (ADR-003)
• feat(2meet-data-optimizer): write flat-table data back to native meta
• feat(2meet-data-optimizer): warn when HivePress / WooCommerce run without their AddOn
• docs(2meet-data-optimizer): partner self-registration guide and deprecated AddOn notice
• refactor(2meet-data-optimizer): resolve post_type/group/table mappings through the registry
• refactor(2meet-data-optimizer): remove HPCT legacy from core
• refactor(2meet-data-optimizer): stop registering HivePress entity groups in core
• feat(2meet-data-optimizer): reconcile post rows written to the wrong group table
• fix(2meet-data-optimizer): route post entity keys by post_type
• feat(2meet-data-optimizer): guard orphaned flat-table groups
• fix(2meet-data-optimizer): report entity group name collisions instead of silently dropping
• refactor(2meet-data-optimizer): delete dead HivePress defaults and hardcoded partner list
• fix(2meet-data-optimizer): filter REST listings collection by post_status and post_type
• fix(2meet-data-optimizer): refuse uninstall while data lives only in flat tables
• fix(2meet-data-optimizer): stop auto-activating entity bridge on install
• fix(2meet-data-optimizer): default misc bucket and garbage filter to off
• test(2meet-data-optimizer): add scale benchmark report (native vs hot vs entity)
• test(2meet-data-optimizer): add scale seeder for 100k vendors / 1M listings
• fix: NinjaFirewall 相容性 — 保護 WAF 設定選項不被重導向
• fix: Schema Registry cold zone 註冊改為冪等（修復欄位重複累積）

Rollout

• Staged: dev22 first (symlink to this branch, HP AddOn active before the core), then merge and roll out to the other sites
• Do not merge before the dev22 verification is done

Hardening 2.0 for `2meet-data-optimizer` — the backlog PRs committed on `hardening/2.0` (see `dev30/notes/pr-backlog.md`, Completed Log). ## Commits - fix(2meet-data-optimizer): compare empty strings correctly when retiring a group - refactor(2meet-data-optimizer): retire the SSO AddOn recommendation - feat(2meet-data-optimizer): group-scoped native write-back and group retirement - refactor(2meet-data-optimizer): stop registering the sso group in core - perf(2meet-data-optimizer): cache found-rows counts for routed queries - perf(2meet-data-optimizer): route status and date ordering to entity tables - feat(2meet-data-optimizer): store post_status and post_date copies in post entity tables - feat(2meet-data-optimizer): flag new Hot zone registrations as deprecated - feat(2meet-data-optimizer): support composite indexes on entity groups - docs(2meet-data-optimizer): decide hot table vs entity table consolidation (ADR-003) - feat(2meet-data-optimizer): write flat-table data back to native meta - feat(2meet-data-optimizer): warn when HivePress / WooCommerce run without their AddOn - docs(2meet-data-optimizer): partner self-registration guide and deprecated AddOn notice - refactor(2meet-data-optimizer): resolve post_type/group/table mappings through the registry - refactor(2meet-data-optimizer): remove HPCT legacy from core - refactor(2meet-data-optimizer): stop registering HivePress entity groups in core - feat(2meet-data-optimizer): reconcile post rows written to the wrong group table - fix(2meet-data-optimizer): route post entity keys by post_type - feat(2meet-data-optimizer): guard orphaned flat-table groups - fix(2meet-data-optimizer): report entity group name collisions instead of silently dropping - refactor(2meet-data-optimizer): delete dead HivePress defaults and hardcoded partner list - fix(2meet-data-optimizer): filter REST listings collection by post_status and post_type - fix(2meet-data-optimizer): refuse uninstall while data lives only in flat tables - fix(2meet-data-optimizer): stop auto-activating entity bridge on install - fix(2meet-data-optimizer): default misc bucket and garbage filter to off - test(2meet-data-optimizer): add scale benchmark report (native vs hot vs entity) - test(2meet-data-optimizer): add scale seeder for 100k vendors / 1M listings - fix: NinjaFirewall 相容性 — 保護 WAF 設定選項不被重導向 - fix: Schema Registry cold zone 註冊改為冪等（修復欄位重複累積） ## Rollout - Staged: dev22 first (symlink to this branch, HP AddOn active before the core), then merge and roll out to the other sites - Do not merge before the dev22 verification is done

wpdev added 29 commits 2026-09-26 07:29:23 +08:00

fix: Schema Registry cold zone 註冊改為冪等（修復欄位重複累積） ... 9f587c39dc

三個 zone 索引的寫入方式並不一致：
- hot  -> hot_columns[post_type][column]  以 column 為 key，天生冪等
- warm -> warm_fields[meta_key]           以 meta_key 為 key，天生冪等
- cold -> cold_fields[post_type][]        append，無去重

而 wpdo_register_fields 本來就會被觸發多次：核心自身於 plugins_loaded:4
觸發，主檔另有 late-bind safety net 於 :30 再觸發一次（讓在 :6 之後才
bootstrap 的 AddOn 趕上）；加上主外掛與其 AddOn 可能同時註冊同一批欄位。

實測影響：某站台 cold_fields['hp_vendor'] 累積到 35 筆但只有 9 個相異值，
每個 key 重複 4 次。修正後為 9 筆、零重複。

修法：cold 分支加入 in_array() 去重，使 register() 對同一
(post_type, meta_key) 成為冪等操作，與 hot / warm 既有行為一致。

驗證：核心單元測試 587 tests / 1156 assertions 全綠；
wp wpdo doctor 於兩個站台皆 0 FAIL。

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

fix: NinjaFirewall 相容性 — 保護 WAF 設定選項不被重導向 ... 9fa84845be

評估 NinjaFirewall (WP Edition) 4.9 的相容性，結論是兩者可共存且
不需要開發 AddOn（該外掛全 codebase 零個 apply_filters('nfw_*') /
do_action('nfw_*')，官方相容手段全在部署層）。但核心有一個隱患必須補。

TMDO_Options_Manager::register_settings_group() 以 pre_update_option_{key}
回傳 $old_value，讓選項不再落地 wp_options、改存專屬設定表。而
NinjaFirewall 的 Full WAF 走 auto_prepend_file，在 WordPress 載入前就以
原生 mysqli 直查 wp_options 取 nfw_options / nfw_rules。一旦這些鍵被
重導向，WAF 會讀不到設定而靜默停止防護 —— 不報錯、不寫 log。

nfw_rules 約 77KB 且 autoload=auto，正是 autoload 瘦身最誘人的目標，
因此這條路徑並非理論風險。

Added
- PROTECTED_OPTIONS 常數與註冊守衛（nfw_options / nfw_rules / nfw_checked），
  命中時發出 _doing_it_wrong()。守衛置於方法開頭，全部鍵都被擋時提前返回，
  不再建立空的設定表。
- tests/unit/OptionsManagerProtectedTest.php（4 tests / 10 assertions），
  鎖住「受保護鍵絕不會被掛上 pre_option_* / pre_update_option_* 攔截」。
- docs/WAF-COMPATIBILITY.md：模式差異、symlink 多租戶部署、WP SaaS 開站
  流程與驗證清單、三條開發約束、實測風險矩陣。

Changed
- Migration Wizard 輪詢 500ms → 2s，與四個 stress-test 面板一致。
  原本 2 req/s 打同一 REST endpoint，易觸發 WAF rate-limit 與 bot 偵測。

autoload 最佳化不受影響：optimize_autoload() 只改 autoload 欄位、不刪列，
而 Full WAF 的 SELECT * 不看 autoload。

驗證：591 tests / 1166 assertions 通過，PHPCS 零違規，版本一致性 1.0.2。
dev30 於 Full WAF 與 WP WAF 兩種模式下實測，firewall log 中 TMDO 相關
攔截 0 筆。

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdjXAU473eekjPBB8vPVRS

test(2meet-data-optimizer): add scale seeder for 100k vendors / 1M listings ... 8fc1dc1f1c

- Seed a HivePress-shaped dataset three ways (native meta, entity tables,
  hot table) with flat tables built by TMDO's own schema code
- Refuse any database not named *_bench before the bootstrap connects;
  bootstrap now honours a pre-defined ABSPATH for the wp-admin stub
- Full scale seeds 9.5M postmeta rows in 7m25s; 0 value mismatches

Verify: TMDO_TEST_DB_NAME=wp_wpdo_bench php tests/bench/seed.php
  --vendors=100000 --listings=1000000; unit 600 OK, integration 416 OK
PR: PR-004

test(2meet-data-optimizer): add scale benchmark report (native vs hot vs entity) ... d3b72bd1af

- Benchmark 7 scenarios at 100k vendors / 1M listings with SQL shaped like
  WP_Query, TMDO_Query_Router and TMDO_Post_Query_Router
- Native meta_query takes 14-17s; flat tables bring searches to 0.3-0.6s
- Hot table lacks an hp_vendor index (3.4s); entity lacks composite indexes

Verify: TMDO_TEST_DB_NAME=wp_wpdo_bench php tests/bench/run.php --iterations=20
PR: PR-005

fix(2meet-data-optimizer): default misc bucket and garbage filter to off ... 151aadd661

- Both term/comment filters now default to disabled for new installs, so
  activating the plugin no longer reroutes or drops other plugins' meta
- One-time maybe_upgrade() migration keeps the misc bucket on for sites
  that already hold misc rows and never set the toggle (data stays readable)
- Admin toggles show the same defaults as the filters

Verify: phpunit-integration --filter 'defaults_false|preserve_default';
  unit 600 OK, integration 420 OK
PR: PR-006

fix(2meet-data-optimizer): stop auto-activating entity bridge on install ... fc0f018a94

- install() no longer switches the Hook Bus on or puts user/term/comment
  into dual_write; the now-unused maybe_autoactivate_entity_bridge() is gone
- Hook Bus and Mode_Manager defaults are off/disabled; sites with stored
  modes (incl. aeav_only) keep them since only unset keys use defaults
- Guard run_dbdelta()'s upgrade.php require like install_v2_tables() so
  install() can run under the integration test stub

Verify: InstallerV2Test::test_install_does_not_enable_entity_bridge,
  ModeManagerDefaultsTest; unit 602 OK, integration 421 OK
PR: PR-007

fix(2meet-data-optimizer): refuse uninstall while data lives only in flat tables ... b407f235ac

- uninstall.php checks every site first and wp_die()s (keeping tables,
  options and plugin files) on aeav_only modes, misc rows, or zone
  modules past cutover; a failed bootstrap also refuses
- Multisite now checks and cleans every site: network activation is always
  false at uninstall, so only the main site was being cleaned before
- Drop the inline fallback DROP loop, unreachable now that a missing
  helper refuses instead

Verify: UninstallGuardTest (8 tests incl. running uninstall.php single and
  multisite); unit 602 OK, integration 429 OK
PR: PR-008

fix(2meet-data-optimizer): filter REST listings collection by post_status and post_type ... 9dc4516ca0

- GET /wpdo/v1/listings rejects unregistered or non-viewable post types (400) and joins posts so Zone A only lists published posts of that type
- WP_Query fallback now returns only show_in_rest hot columns, matching the Zone A path
- Verify: core unit 605 / integration 432 OK (new RestApi tests); 1M bench: page 7ms, total COUNT 0.12s → 1.7s (tracked in PR-030)
- PR: PR-015

refactor(2meet-data-optimizer): delete dead HivePress defaults and hardcoded partner list ... 07db7734cf

- Remove never-called register_hivepress_defaults() and core boot probes for AddOn classes that load at plugins_loaded:3/:6 and self-register (8 partner list entries, WC orders interceptor, HP transient filter)
- Keep core-owned TMDO_Member_Fields / TMDO_Post_Fields registration unchanged
- Verify: CoreBoundaryTest guard added; core unit 606 / integration 432, HP 141/49, WC 10/22 OK
- PR: PR-016

fix(2meet-data-optimizer): report entity group name collisions instead of silently dropping ... e9d8696c93

- register_group() keeps the first definition but records a field diff (added/removed/changed) when the same entity/group is re-registered differently; identical re-registration stays silent
- Surface collisions via Site Health (wpdo_entity_group_collisions), the admin Doctor tab, and wp wpdo doctor; warning log throttled to once a day
- Verify: EntityRegistryCollisionTest (7); core unit 613 / integration 432, HP 141/49, WC 10/22 OK
- PR: PR-017

feat(2meet-data-optimizer): guard orphaned flat-table groups ... 1653011f4f

- On init:1, re-register aeav_only groups whose flat table exists and whose definition is in wpdo_registry_meta but no active plugin registers them, so their data stays readable (routing only, never DDL)
- Keys owned by a live group, or with rows in native meta (newer data written while orphaned), are left alone; the native-meta check is cached for a day
- Surface restored groups via Site Health (wpdo_orphaned_entity_groups), the admin Doctor tab, and wp wpdo doctor
- Verify: EntityRegistryRestoreTest (9), OrphanGroupRestoreTest (7); core unit 622 / integration 439, HP 141/49, WC 10/22 OK; dry-run on dev20–22 restores 16/17/4 groups, keeps hp_taxonomy hp_sort_order/hp_icon on native
- PR: PR-018

fix(2meet-data-optimizer): route post entity keys by post_type ... 3f4fe52e1b

- Entity groups can declare post_types; get_field() resolves a post's key against its own type's groups first, then unscoped ones (legacy last-wins lookup kept for callers without a post type)
- Hook Bus and the post query router pass the post type, so a listing's hp_rating / hp_status / hp_verified map to hp_listing_core instead of the vendor/request tables; core HP groups declare their post types (schema hashes unchanged)
- Behind tmdo_post_scoped_routing: on for sites without post flat rows, off where rows may sit in the wrong table until PR-034 reconciles them (dry-run: dev20–22 off, dev23/24/30/31/40 on)
- Verify: EntityRegistryScopeTest (8), PostScopedRoutingTest (4); core unit 630 / integration 443, HP 144/49, WC 10/22 OK
- PR: PR-033

feat(2meet-data-optimizer): reconcile post rows written to the wrong group table ... e0683a19b1

- TMDO_Post_Group_Reconciler copies non-NULL values that legacy routing stored in another group's table into the post type's own group (NULL/missing legacy values keep the scoped value), resumable via a cursor, with a catch-up pass for rows updated during the run, then switches on tmdo_post_scoped_routing
- CLI: wp tmdo post-reconcile-groups [--dry-run] [--batch=<n>]; registry exposes get_group_post_types()
- Verify: PostGroupReconcilerPlanTest (4), PostGroupReconcilerTest (6); core unit 635 / integration 449, HP 145/49, WC 10/22 OK; read-only dry-run: dev20 320 values / 0 overwrites, dev21/22 none
- PR: PR-034

refactor(2meet-data-optimizer): stop registering HivePress entity groups in core ... 1eedaa9b3c

- Drop hp_listing_core / hp_request_core / hp_vendor_core from TMDO_Post_Fields and hp_user from TMDO_Member_Fields; the HivePress AddOn registers identical definitions (PR-019/020a/033b)
- Tests: core asserts it registers none of them; HP-specific core tests removed (covered by the AddOn); SyncBridgeEntityGuardTest registers its own hp_price group
- Verify: core unit 633 / integration 449, HP 145/49, WC 10/22 OK
- Deploy: activate the HivePress AddOn on dev20/21/22 first
- PR: PR-020b

refactor(2meet-data-optimizer): remove HPCT legacy from core ... 8a1c9c0353

- Feature flags keep only the live AddOn modules (wc_orders, latepoint) as ADDON_MODULES / addon_modules(); drop map_hpct_status() and the 7 HivePress HPCT modules whose interceptors were removed in PR-014
- Remove HPCT detection/notice (Compatibility, core), the admin HPCT import tab and status row, CLI import-hpct, the 7 advisor rules for dead modules, and the removed interceptors from COEXIST_WHITELIST
- Verify: NoHpctLegacyTest guard; core unit 635 / integration 449, HP 145/49, WC 10/22 OK; all sites have every module idle and never imported HPCT
- PR: PR-020c

refactor(2meet-data-optimizer): resolve post_type/group/table mappings through the registry ... 0603537f0a

- TMDO_Post_Fields::post_type_for_group() / groups_for_post_type() derive HivePress-style groups from their registry post_type scope (core keeps its own attachment / wc_product / nav_menu_item map); the three copy-pasted switches and the query router's POST_TYPE_GROUP_MAP use them
- Term/comment backfill, shadow verifier and CLI take their groups from the registry (TMDO_Term_Comment_Backfill::registered_groups()); installer drops the hp_* entries already covered by its table patterns; REST listings default post type is filterable (tmdo_rest_default_post_type, default 'post')
- Verify: NoHpMappingsTest guard + mapping/default tests; core unit 640 / integration 449, HP 146/49, WC 10/22 OK
- PR: PR-020e

docs(2meet-data-optimizer): partner self-registration guide and deprecated AddOn notice ... 3d650eb848

- Add docs/PARTNER-REGISTRATION.md: TMDO_Anti_EAV_Aware bridge setup (plugins_loaded:3), table and entity-group registration with post_types scopes, frozen definitions, and the AddOn → self-registration migration checked with [COLLISION]/[ORPHAN]
- TMDO_Deprecated_Addons_Notice warns administrators while any of the 8 in-house partner AddOns is active (site or network)
- Trait register_entity_fields() forwards an optional $args (post_types) to the registry
- Verify: DeprecatedAddonsNoticeTest (4); core unit 645 / integration 449, HP 148, WC 10 OK
- PR: PR-021

feat(2meet-data-optimizer): warn when HivePress / WooCommerce run without their AddOn ... c84d2409b7

- TMDO_Compatibility::missing_integration_addons() reports active HivePress / WooCommerce whose AddOn bootstrap class is absent
- Surface it as Site Health test wpdo_missing_integration_addons (also on the admin Doctor tab) and an administrator notice (TMDO_Missing_Addons_Notice)
- Verify: MissingIntegrationAddonsTest (5, class stand-ins in separate processes); core unit 651 / integration 449, HP 148, WC 10 OK; read-only check: dev20/21 HivePress+WooCommerce, dev22 HivePress, others clean
- PR: PR-035

feat(2meet-data-optimizer): write flat-table data back to native meta ... d86c0a7bac

- TMDO_Native_Restorer copies an entity's flat-table values into its native meta table so the value each key reads today is what native returns afterwards: the owning group (by post type for posts) wins, values are stored as WP stores them, NULL removes the native row
- Resumable per-group id cursor, catch-up pass for rows updated during the run, optional demote to dual_write; CLI wp tmdo bridge-restore-native <entity> [--dry-run] [--batch=<n>] [--demote]
- Verify: NativeRestorerTest (5, user) + NativeRestorerPostTest (2, scoped vs legacy routing); core unit 652 / integration 456, HP 148, WC 10 OK; scale estimate dev21 user ~5.1M / post ~4.0M flat rows
- PR: PR-031

docs(2meet-data-optimizer): decide hot table vs entity table consolidation (ADR-003) ... d6b2e417f4

- Compare the Hot zone and Entity bridge (capabilities, 1M-listing benchmark, per-site usage: no 2meet-DO site uses the Hot zone; only legacy dev34 / dev10 hold Hot copies of postmeta)
- Decision (user, 2026-09-26): converge on Entity; freeze the Hot zone, skip PR-026, keep PR-027, move Hot-only HivePress fields into new Entity groups, stop Hot registrations
- PR: PR-025

feat(2meet-data-optimizer): support composite indexes on entity groups ... 65c75dfc8d

- register_group() accepts $args['indexes'] (name => ordered keys); indexes on
  unknown keys are dropped. Kept outside the field definition, so schema
  hashes are unchanged.
- Schema_Manager::ensure_group_indexes() adds missing cidx_* indexes to the
  existing flat table in place; the applied definition is remembered in
  tmdo_entity_indexes so later requests skip SHOW INDEX.
- Bench (1M listings, scenario 2): Entity p50 337 ms -> 278 ms with
  (hp_verified, hp_price), on par with Hot (269 ms).
- Verify: core unit 656 / integration 459 green, phpcs clean
- PR: PR-027

feat(2meet-data-optimizer): flag new Hot zone registrations as deprecated ... f4eee2338b

- ADR-003 step 4 (core side): TMDO_Schema_Registry::register() raises
  _doing_it_wrong() the first time each provider registers a zone=hot
  field in a request (zone omitted defaults to hot). Fields still
  register, so existing hot data stays readable.
- Cold / warm / archive registrations are unaffected.
- Test bootstrap's _doing_it_wrong stub now records calls.
- Verify: core unit 658 / integration 459, HP 142/49, WC 10/22 green,
  phpcs clean
- PR: PR-038

feat(2meet-data-optimizer): store post_status and post_date copies in post entity tables ... aeca12b41d

- TMDO_Post_Status_Sync: post group tables get post_status / post_date
  columns (posts' collation) and an (post_status, post_date) index.
  Brand-new empty tables get them on creation; existing tables only via
  `wp tmdo post-status-sync [--dry-run] [--batch]`, never as DDL on a
  populated table in a web request. Per-group state in
  tmdo_post_status_columns ('columns' | 'ready').
- transition_post_status refreshes the copies; Hook Bus upserts that
  create a post row fill them in (existing rows keep theirs).
- Bench (1M rows): add columns 0.05 s, index 5.3 s, batched backfill 32 s,
  0 mismatches afterwards.
- Verify: core unit 659 / integration 466 green, phpcs clean
- PR: PR-028

perf(2meet-data-optimizer): route status and date ordering to entity tables ... 754f904e3b

- TMDO_Post_Query_Router: when a group's post_status / post_date copies
  are ready and none is NULL (one index probe per group per request), a
  single-post-type search with explicit statuses and date ordering INNER
  JOINs the flat table, filters the copied status, orders by the copied
  post_date and skips GROUP BY. Otherwise the query keeps its old shape.
- New posts_orderby filter; bench gains an `entity+copy` variant.
- Bench (1M, with SQL_CALC_FOUND_ROWS): scenario 1 p95 3,739 -> 773 ms
  (p50 670 -> 770); scenario 2 p50 356 -> 448 ms. Without found-rows the
  same shape runs in 8 ms (PR-030).
- Verify: core unit 659 / integration 471 green, phpcs clean
- PR: PR-029

perf(2meet-data-optimizer): cache found-rows counts for routed queries ... 10671e7b78

- TMDO_Post_Query_Router drops SQL_CALC_FOUND_ROWS from routed searches
  (posts_request) and answers found_posts_query from a COUNT(*) of the
  same query, cached in the object cache under posts' last_changed.
- Hook Bus flat post writes and deletes move posts' last_changed: in
  aeav_only they skip update_metadata()'s own hooks, so query caches
  would otherwise outlive the write.
- Bench (1M): cached page 8 ms (was 694 / 363 ms for scenarios 1 / 2);
  after invalidation 8 ms + COUNT 608 / 344 ms, on par with before.
- REST X-WP-Total COUNT is on the frozen Hot zone path (ADR-003): not
  changed.
- Verify: core unit 659 / integration 475, HP 142/49, WC 10/22 green,
  phpcs clean
- PR: PR-030

refactor(2meet-data-optimizer): stop registering the sso group in core ... c70dc99bf9

- TMDO_Member_Fields no longer registers user/sso; the definition moved
  unchanged (hash 03543f19) to 2meet-data-optimizer-sso-addon.
- missing_integration_addons(): 2meet-hub-core or 2meet-spoke-sso without
  the SSO AddOn is reported (admin notice + Site Health).
- The deprecated-AddOn notice points hub / spoke users to the SSO AddOn.
- Sites must activate the SSO AddOn before this ships (PR-041); aeav_only
  sites without it fall back to orphan-group restore.
- Verify: core unit 659 / integration 475, SSO 6, HP 142/49, WC 10/22
  green, phpcs clean
- PR: PR-040

feat(2meet-data-optimizer): group-scoped native write-back and group retirement ... 44a188b7ee

- TMDO_Native_Restorer::run() takes an optional group; the CLI gains
  `bridge-restore-native <entity> --group=<g>`.
- New retire(): once native meta holds every non-NULL value of a group's
  flat table (checked against the persisted field definitions), forget
  its registry_meta row and rename the table to <table>_retired_<Ymd>, so
  orphan restore no longer routes its keys to the flat table. Refused
  while a plugin still registers the group or any value differs.
  CLI: `--group=<g> --retire`.
- For retiring the user `sso` group (SSO AddOn deprecation).
- Verify: core unit 659 / integration 479 green, phpcs clean
- PR: PR-042

refactor(2meet-data-optimizer): retire the SSO AddOn recommendation ... ecf4ff4938

- missing_integration_addons() no longer asks for the SSO AddOn when
  2meet-hub-core / 2meet-spoke-sso are active: they register their own
  tables and the `sso` values belong in usermeta (benchmark: no
  measurable gain from the flat table for by-user-id access).
- `sso` joins the deprecated AddOns; for hub / spoke / sso the notice says
  they go without replacement and to run
  `wp tmdo bridge-restore-native user --group=sso --retire` first.
- Verify: core unit 658 / integration 479 green, phpcs clean
- PR: PR-043

fix(2meet-data-optimizer): compare empty strings correctly when retiring a group ... 08492dd795

- retire() read native meta with wpdb::get_col(), which (via get_var())
  returns null for an empty string, so a flat '' written back as '' was
  counted as a mismatch and blocked the retirement. It now reads raw rows
  with get_results().
- The integration test wpdb stub's get_var() / get_col() now read '' as
  null like the real wpdb, so tests see WordPress behaviour.
- Found writing back the sso group on dev21 / dev22 (picture_url = '').
- Verify: core unit 658 / integration 480 green, phpcs clean
- PR: PR-042 follow-up

wpdev added 1 commit 2026-09-26 07:45:09 +08:00

chore(2meet-data-optimizer): make the hardening branch pass PHPStan and PHPCS ... b917e45c8c

- CI PHPStan (level 6, baseline for pre-existing debt) failed on 35 errors in
  code added on hardening/2.0: missing iterable value types (PHPDoc only), a
  redundant method_exists() in uninstall.php, and the new WP-CLI commands
  registered as array('Class', 'instanceMethod') — now array(new Class(), ...)
- Local runs had been masked by a PHPStan tmpDir shared with the act CI runner
  (cached container pointing at a removed phar); use a private tmpDir
- Verify: phpstan (private tmpDir) no errors, phpcs clean on changed files,
  phpunit Unit 658 OK; dev22 (running this branch) CLI post-status-sync /
  bridge-restore-native dry runs OK

wpdev merged commit 2540d7c0e2 into main 2026-09-26 10:20:24 +08:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

wpdev

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wpdev/2meet-data-optimizer#3